Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make map functions distinct with each invocation #646

Merged
merged 1 commit into from
Jul 5, 2017

Conversation

sebastianrothbucher
Copy link
Contributor

Overview

Issue 548 points out that tests fail randomly when using ad-hoc queries (i.e. create a design doc, query it, remove it again). Though I can't reproduce it (not even by doing this cycle three times in a row without wait in-between), there is a solution by simply adding comments to the map function (hence changing the signature, allowing two otherwise similar views to co-exist. As it's hardly production relevant (design docs likely won't and probably shouldn't be created and removed all the time - it's a performance no-go in most cases), we actually get better tests as they really indicate if things go wrong (instead of failing randomly and being ignored after some time).

In short: improves the quality of javascript tests

Testing recommendations

This IS a test

GitHub issue number

Issue 548

Related Pull Requests

(none)

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • n/a Documentation reflects the changes;

@wohali
Copy link
Member

wohali commented Jul 5, 2017

Once Travis passes in about 20 minutes, a big +1. Thanks for this!

@wohali wohali merged commit 858088e into apache:master Jul 5, 2017
@sebastianrothbucher sebastianrothbucher deleted the Stabilize_adhoc branch July 5, 2017 20:52
@sebastianrothbucher
Copy link
Contributor Author

great!

@kocolosk
Copy link
Member

kocolosk commented Jul 5, 2017

Yes, thanks. This is exactly the sort of thing I had in mind for #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants