Make map functions distinct with each invocation #646
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Issue 548 points out that tests fail randomly when using ad-hoc queries (i.e. create a design doc, query it, remove it again). Though I can't reproduce it (not even by doing this cycle three times in a row without wait in-between), there is a solution by simply adding comments to the map function (hence changing the signature, allowing two otherwise similar views to co-exist. As it's hardly production relevant (design docs likely won't and probably shouldn't be created and removed all the time - it's a performance no-go in most cases), we actually get better tests as they really indicate if things go wrong (instead of failing randomly and being ignored after some time).
In short: improves the quality of javascript tests
Testing recommendations
This IS a test
GitHub issue number
Issue 548
Related Pull Requests
(none)
Checklist