Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stable and update support to Mango #628

Merged
merged 1 commit into from
Jul 17, 2017
Merged

Add stable and update support to Mango #628

merged 1 commit into from
Jul 17, 2017

Conversation

garrensmith
Copy link
Member

@garrensmith garrensmith commented Jul 3, 2017

This brings mango inline with views by supporting the new options
stable and update.

Fixes #621

Testing recommendations

See the test for an example on how to test. I'm not really sure of a way to test the stable option.

GitHub issue number

#621

Checklist

@tonysun83
Copy link
Contributor

stable and update are replacing stale right? will the same options work for text indexes?

@garrensmith
Copy link
Member Author

garrensmith commented Jul 5, 2017 via email

@janl
Copy link
Member

janl commented Jul 16, 2017

Please see #621 (comment) ff. for comment.

This brings mango inline with views by supporting the new options
`stable` and `update`.

Fixes #621

chore: whitespace

feat: add stale option to Mango

fix: opts parsing
@janl
Copy link
Member

janl commented Jul 16, 2017

added stale, rebased with master and squashed my commits.

Copy link
Member

@janl janl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tonysun83
Copy link
Contributor

@garrensmith @janl I like the addition of stale! We'll need to add in support for text indexes for stale as well. This way we are at least trying to be consistent across index options. We may also some logic if the user specifies stable or update for text indexes (which doesn't support that option, but we may already just ignore invalid options). We could move those changes into another PR if this a pressing option we want.

@apache apache deleted a comment from ditta95aR Jul 17, 2017
@davisp
Copy link
Member

davisp commented Jul 17, 2017

+1

@tonysun83 I'd make any changes to the text indexes as new work. I checked and mango_cursor_text will ignore any unknown options so there's no breakage there.

@tonysun83
Copy link
Contributor

Sounds good. +1

@iilyak
Copy link
Contributor

iilyak commented Jul 17, 2017

Merging it in on Garren's behalf since he is on vacation at the moment.

@iilyak iilyak merged commit addccbc into apache:master Jul 17, 2017
@garrensmith garrensmith deleted the add-stable-to-mango branch December 12, 2019 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants