Whait db close a little bit before failing test #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, didn't know we have |
|
@eiri: What timeout value would you recommend? I am considering 500. |
Databases are closed asynchronously. However it was not accounted for in the test case. This commit waits database to close before it makes a decission to abort the test. I.e. if test case detects that database is still opened after 1 second it considers it as failure.
a45003c
to
4683f51
Compare
|
@iilyak hard to guess, to be honest, 500 or 1000 both look good for me. test_util's |
|
@wohali: Sorry for the delay. |
|
@iilyak Hey I'm just glad people are starting to help ;) |
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
Improvement to "3.1.2.2. Reduce and Rereduce Functions" argument description apache#517 Co-authored-by: Sunitha Rajaretnam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Databases are closed asynchronously. However it was not accounted for in
the test case. This commit waits database to close before it makes a
decision to abort the test. It uses default timeout of 5 sec.
I.e. if test case detects that database is still opened after 5 sec
it considers it as failure.
Testing recommendations
make eunit apps=couch_index tests=compaction_test
Checklist