More QuickJS scanner improvements #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9cb4d15
to
2b88712
Compare
jiahuili430
approved these changes
Jul 6, 2024
* Fix incorrect handling of view `lib`s. These should be under `views` not at the
top level.
* Reduce false positive log noise when both results fail with a similar errors like
compilation errors or a common TypError but their exact message format will be
different. An example I noticed was:
```
{error,{throw,{compilation_error,<<"SyntaxError: unexpected token in expression: 'if' ...
{error,{throw,{compilation_error,<<"Expression does not eval to a function. ...
```
* Make the scanner a bit more resilient and skip unsupported junk like
map/views/filters that are not the expected object or types. Previously we
asssumed if they exist (no undefined) they will be valid.
2b88712
to
03c9542
Compare
jiahuili430
approved these changes
Jul 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect handling of view
libs. These should be underviewsnot at the top level.Reduce false positive log noise when both results fail with a similar errors like compilation errors or a common TypError but their exact message format will be different. An example I noticed was: