Make app and release versions uniform #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-r81
approved these changes
Jun 5, 2024
nickva
force-pushed
the
make-versions-uniform
branch
from
f4aeb54
to
9ac6545
Compare
Previously, some apps used `git` versions, others had a fixed version number. Each approach has it's benefits and downsides but since're using git in most cases, let's use git for all of them.
nickva
force-pushed
the
make-versions-uniform
branch
from
9ac6545
to
e3a0540
Compare
big-r81
added a commit
to apache/couchdb-glazier
that referenced
this pull request
Jun 22, 2024
The CouchDB version was extracted from the `rel/couchdb/releases/start_erl.data` file. This version string was removed in [1,2]. Since we have a file (`version.mk`) with the released CouchDB version, use this and extract the number from here. [1] apache/couchdb#5085 [2] apache/couchdb#5078
big-r81
added a commit
to apache/couchdb-glazier
that referenced
this pull request
Jun 22, 2024
The CouchDB version was extracted from the `rel/couchdb/releases/start_erl.data` file. This version string was removed in [1,2]. Since we have a file (`version.mk`) with the released CouchDB version, use this and extract the number from here. [1] apache/couchdb#5085 [2] apache/couchdb#5078
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, some apps/release used
gitversion others had a fixed version number. Each approach has it's benefits and downsides but since we're using git in most cases, let's be uniform and use that uniformly.