Move priv direcotry gitignore from quickjs app to main gitignore #5076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `.gitignore` file in priv was mainly there to keep the directory around in git. But that's a bit dirty as the debian packager will complain if we package the `.gitignore`, as it packages the whole `priv` directory. To fix, move the .gitignore entries to the app's main .gitignore, and make sure to create and clean the whole priv directory as needed.
big-r81
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
.gitignorefile in priv was mainly there to keep the directory around in git. But that's a bit dirty as the debian packager will complain if we package the.gitignore, as it packages the wholeprivdirectory.To fix, move the
.gitignoreentries to the app's main.gitignore, and make sure to create and clean the whole priv directory as needed.