Prevent release from generating ez archives #5073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test, make two copies of the src directory, one with asdf shell erlang 26 the other with 25. Instead of It should look like |
nickva
force-pushed
the
fix-releases-no-more-ez-archive
branch
from
43292ac
to
2311015
Compare
jaydoane
approved these changes
May 31, 2024
Erlang 26 removed the ability to create ez archive files in releases. We had to remove the `excl_archive_filters` option from our reltool.config file [1], as otherwise we couldn't make releases on 26 (`make release` barfed). However, that meant on 24 and 25 our releases are generated with beam files packed in lots of silly .ez archives, which is not great. Sadly, since 26, refuses to silently ignore `excl_archive_filters` option, we have to use a script file and only apply the config on <26 versions. [1] a4bbb87
nickva
force-pushed
the
fix-releases-no-more-ez-archive
branch
from
2311015
to
4f87898
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Erlang 26 removed the ability to create ez archive files in releases. We had to remove the
excl_archive_filtersoption from our reltool.config file [1], as otherwise we couldn't make releases on 26 (make releasebarfed). However, that meant on 24 and 25 our releases would be generated with beam files packed in lots of silly .ez archives, which is not great.Sadly, since 26, refuses to silently ignore
excl_archive_filterswe have to use a script file and only apply the config on <26 versions.[1] a4bbb87