Handle missing VDU better in In QuickJS scanner plugin #5058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
force-pushed
the
check-for-vdu-in-quickjs-scanner
branch
from
076c94b
to
536807d
Compare
jaydoane
approved these changes
May 17, 2024
@jaydoane Good idea. Will add a few tests for VDU only, filter only, maps only etc. Will need to check if process proc errors were raised, we record those in |
Previously we tried to run the VDU query prompt even if there was not VDU. That would have yielded a match anyway as both result in an error, but it added noise to the logs. Handle the missing VDU like we handle the missing filters in filter_doc_validate.
nickva
force-pushed
the
check-for-vdu-in-quickjs-scanner
branch
from
536807d
to
910fc26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we tried to run the VDU query prompt even if there was not VDU. That would have yielded a match anyway as both result in an error, but it added noise to the logs.
Handle the missing VDU like we handle the missing filters in filter_doc_validate.