Fix case clause error in replicator _scheduler/docs response #5008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-r81
approved these changes
Mar 16, 2024
pgj
reviewed
Mar 16, 2024
src/couch_replicator/test/eunit/couch_replicator_scheduler_docs_tests.erl
Show resolved
Hide resolved
nickva
force-pushed
the
jenkins-fix-replicator-nil-case-clause
branch
2 times, most recently
from
54e927e
to
e8fb826
Compare
When a job is completing, there is a period of time when the document isn't updated yet with the state, and it's also not present in the scheduler ets table. In that case we return `nil`, but we don't account for that case in the _scheduler/docs fabric calls. To fix it, account for `nil` whenever we get the doc state.
nickva
force-pushed
the
jenkins-fix-replicator-nil-case-clause
branch
from
e8fb826
to
6aa04d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a job is completing, there is a period of time when the document isn't updated yet with the state, and it's also not present in the scheduler ets table. In that case we return
nil, but we don't account for that case in the _scheduler/docs fabric calls.To fix it, account for
nilwhenever we get the doc state.