Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nouveau): change path handling on Windows (and *nix) for tests #4998

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

big-r81
Copy link
Contributor

@big-r81 big-r81 commented Feb 29, 2024

run tests on Windows too; change path handling

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Well done, @big-r81

Screenshot 2024-02-29 at 11 32 25 PM

I had noticed spotless complained with:

Screenshot 2024-02-29 at 11 33 56 PM

Line ending windows vs unix perhaps?

I had just reformatted it just to get to ./dev/run

That's with java 11.0.22 (temurin)

@big-r81
Copy link
Contributor Author

big-r81 commented Mar 1, 2024

Was this a complete fresh checkout? Could this relate to this change (I don't think so)?

@nickva
Copy link
Contributor

nickva commented Mar 1, 2024

@big-r81 it was the commit from the pr:

Screenshot 2024-03-01 at 11 05 19 AM

I did a new configure and make but may have not done a git clean -xffd. So maybe some artifacts were left from before?

At any rate, it's not relevant for this PR just thought I'd mention it in case we see it again.

@big-r81 big-r81 merged commit b222951 into main Mar 1, 2024
14 checks passed
@big-r81 big-r81 deleted the nouveau/path-handling branch March 1, 2024 19:52
pgj pushed a commit to pgj/couchdb that referenced this pull request Mar 14, 2024
…apache#4998)

and terminate all processes (and child processes) after the test runs.
jiahuili430 pushed a commit to cloudant/couchdb that referenced this pull request Mar 19, 2024
…apache#4998)

and terminate all processes (and child processes) after the test runs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants