Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(fabric): switch to maps for view rows #4984

Merged
merged 1 commit into from
Mar 15, 2024

Commits on Mar 14, 2024

  1. fabric: switch to maps for view rows

    The `#view_row{}` record that is used for capturing messages with
    row data is not flexible enough to have it extended easily.  If
    one wanted to introduce a fresh field, the change would have to be
    propagated through many functions and modules.  Especially, if
    support for mixed-version clusters is a concern, this would come
    with some degree of duplication.
    
    Leverage Erlang/OTP's built-in maps for mitigating this issue and
    offer the view callbacks the `view_row_map` Boolean key in
    `#mrargs.extra` to request this communication format.  This way the
    old record-based format would be still in use unless requested
    otherwise.  This facilitates the smooth interoperability of old
    coordinators and new workers.  In parallel to that, the new
    coordinator could still receive view rows from old workers.
    pgj committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    0fd8c1b View commit details
    Browse the repository at this point in the history