Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix password test timeout #4980

Merged
merged 1 commit into from
Feb 10, 2024
Merged

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Feb 10, 2024

In this test we have to wait for 5 seconds as that's the hardcoded timeout in the hash worker. However let's try to wait just a bit longer (+500msec) in case there a race condition or some schedulers are blocked.

In this test we have to wait for 5 seconds as that's the hardcoded timeout in
the hash worker. However let's try to wait just a bit longer (+500msec) in case
there a race condition or some schedulers are blocked.
Copy link
Contributor

@jaydoane jaydoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Nick!

@nickva nickva merged commit 8f6797b into main Feb 10, 2024
14 checks passed
@nickva nickva deleted the fix-timeout-in-password-cache-test branch February 10, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants