add metrics for fast vs slow password hashing #4976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
force-pushed
the
couch_passwords_metrics
branch
from
517f3ab
to
b90653a
Compare
rnewson
force-pushed
the
couch_passwords_metrics
branch
from
b90653a
to
67d3c08
Compare
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
bump a counter whenever we do a slow or fast password hash, to guide administrators on setting the password cache configuration appropriately and to expose a potential source of slow performance.
Testing recommendations
The counters are visible in the metrics / Prometheus output.
Related Issues or Pull Requests
#4814
Checklist
rel/overlay/etc/default.inisrc/docsfolder