Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve retries in dev/run cluster setup #4953

Merged
merged 1 commit into from
Jan 7, 2024
Merged

Improve retries in dev/run cluster setup #4953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 17 additions & 11 deletions dev/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1104,17 +1104,23 @@ def try_request(
):
while True:
conn = httpclient.HTTPConnection(host, port)
if headers is not None:
conn.request(meth, path, body=body, headers=headers)
else:
conn.request(meth, path, body=body)
resp = conn.getresponse()
if resp.status in success_codes:
result = (resp.status, resp.read())
resp.close()
return result
elif retries <= 0:
assert resp.status in success_codes, "%s%s" % (error, resp.read())
try:
if headers is not None:
conn.request(meth, path, body=body, headers=headers)
else:
conn.request(meth, path, body=body)
resp = conn.getresponse()
if resp.status in success_codes:
result = (resp.status, resp.read())
resp.close()
return result
elif retries <= 0:
assert resp.status in success_codes, "%s%s" % (error, resp.read())
except Exception as e:
if retries <= 0:
print("Connection failed %s %s" % (e, error))
raise e
print("Retrying ... %s " % e)
retries -= 1
time.sleep(retry_dt)

Expand Down