Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for _changes with different parameters #4938

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Add tests for _changes with different parameters #4938

merged 1 commit into from
Jan 3, 2024

Conversation

jiahuili430
Copy link
Contributor

Overview

Add tests for _changes with different parameters

  • style=all_docs
  • include_docs=true
  • conflicts=true

Testing recommendations

make eunit apps=chttpd suites=chttpd_changes_test

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly
  • Changes are covered by tests
  • Any new configurable parameters are documented in rel/overlay/etc/default.ini
  • Documentation changes were made in the src/docs folder
  • Documentation changes were backported (separated PR) to affected branches

@jiahuili430
Add tests for _changes with different parameters
d3bc259 
- style=all_docs
- include_docs=true
- conflicts=true
nickva
nickva approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Well done!

@jiahuili430 jiahuili430 merged commit fb6e209 into main Jan 3, 2024
15 checks passed
@jiahuili430 jiahuili430 deleted the test-changes branch January 3, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickva nickva nickva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jiahuili430 @nickva