Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs/3.3.x): Set docs version numbers dynamically from file #4933

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

big-r81
Copy link
Contributor

@big-r81 big-r81 commented Dec 30, 2023

Load documentation version from local version.mk file.

@big-r81 big-r81 requested a review from nickva December 30, 2023 14:34
@big-r81 big-r81 changed the title feat(docs): Set docs version numbers dynamically from file feat(docs/3.3.x): Set docs version numbers dynamically from file Dec 30, 2023
src/docs/src/conf.py Outdated Show resolved Hide resolved
@big-r81 big-r81 force-pushed the docs/stable-version-number branch 2 times, most recently from 5ed0a1c to a22c3a3 Compare December 30, 2023 19:35
@big-r81
Copy link
Contributor Author

big-r81 commented Dec 30, 2023

Getting this python-black error, which I can’t reproduce locally. Should I merge it anyway or do you have any tips?

src/docs/src/conf.py Outdated Show resolved Hide resolved
src/docs/src/conf.py Outdated Show resolved Hide resolved
Load documentation version from local version.mk file.
@big-r81
Copy link
Contributor Author

big-r81 commented Dec 31, 2023

REMINDER

erlfmt IS NOT python-black.
erlfmt IS NOT python-black.
erlfmt IS NOT python-black.
erlfmt IS NOT python-black.

Thx, @jaydoane 😉 🙄

@big-r81 big-r81 merged commit f7b10d0 into 3.3.x Dec 31, 2023
5 checks passed
@big-r81 big-r81 deleted the docs/stable-version-number branch December 31, 2023 14:51
@big-r81 big-r81 restored the docs/stable-version-number branch December 31, 2023 15:03
@big-r81 big-r81 deleted the docs/stable-version-number branch December 31, 2023 15:06
big-r81 added a commit that referenced this pull request Dec 31, 2023
Load documentation version from local version.mk file.
big-r81 added a commit that referenced this pull request Dec 31, 2023
Load documentation version from local version.mk file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants