couch_passwords:verify should always return false for bad inputs #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janl
approved these changes
Dec 12, 2023
rnewson
force-pushed
the
couch_passwords_very_return_false
branch
from
c7f8d69
to
353856a
Compare
rnewson
force-pushed
the
couch_passwords_very_return_false
branch
from
353856a
to
876fa87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parts of the codebase depend on being able to pass in
nilas the expected hash (e.g, if the user doesn't exist).In commit 21c2dec I enhanced couch_passwords:verify/2 to use OTP 25's new
crypto:hash_equals/2function, but foolishly omitted the final fallback clause of our originalverify/2function. This PR restores it.