fix(mango): communicate rows read for global stats collection
#4908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgj
force-pushed
the
fix/mango/chttpd_stats-integration
branch
from
fc0f16d
to
5bbefac
Compare
chewbranca
approved these changes
Dec 11, 2023
pgj
force-pushed
the
fix/mango/chttpd_stats-integration
branch
from
5bbefac
to
519305b
Compare
pgj
commented
Dec 14, 2023
src/mango/src/mango_cursor_text.erl
Outdated
| ?assertEqual(3, meck:num_calls(couch_stats, increment_counter, 1)), | ||
| ?assertEqual(3, meck:num_calls(mango_execution_stats, incr_docs_examined, 1)), | ||
| ?assertEqual(3, meck:num_calls(mango_execution_stats, incr_results_returned, 1)). | ||
| meck:expect(chttpd_stats, incr_rows, [0], meck:val(ok)), |
There was a problem hiding this comment.
@iilyak, @chewbranca please note that text search will not modify the rows value. Is this acceptable or shall they also update the value? If yes, how?
There was a problem hiding this comment.
I have talked about this with @willholley and @mikerhodes offline. The conclusion was that rows should be equal to reads for text indexes. The distinction between these two categories make difference only for json indexes, especially when covering indexes are in use.
pgj
force-pushed
the
fix/mango/chttpd_stats-integration
branch
2 times, most recently
from
14214d6
to
13477b2
Compare
Besides the execution statistics that could be shown for the user, the number of rows and documents read are tracked separately on the global level. (Which is more like a bug than a feature, but that is out of the scope of this change.) With the introduction of covering indexes, these two have been become different, therefore global counting has to be taught about the number of times when no documents were read but rows only. For text indexes, the number of rows and documents should be the same, the distinction makes sense only for json indexes.
pgj
force-pushed
the
fix/mango/chttpd_stats-integration
branch
from
13477b2
to
33c9881
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides the execution statistics that could be shown for the user, the number of rows and documents read are tracked separately on the global level. (Which is more like a bug than a feature, but that is out of the scope of this change.)
With the introduction of covering indexes, these two have been become different, therefore global counting has to be taught about the number of times when no documents were read but rows only. For
textindexes, the number of rows and documents should be the same, the distinction makes sense only forjsonindexes.Testing recommendations
The changes are covered by the respective portion of the tests:
The global stats should always report the same values as it is added for the (Mango) execution stats.
Checklist