Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flaky fixes for cluster setup #4900

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Dec 7, 2023

Noticed nouveau elixir tests still throw connection refused errors in the finish_cluster setup step. So try to make all the http requests in dev/run use retries. That also helps us DRY out some repeating bits like header auth and json application content type.

We also had an odd import catch error then import again clause. I don't think we intend this to work on python 2 any longer so I cleaned that up as well.

Noticed nouveau elixir tests still throw `connection refused` errors in the
`finish_cluster` setup step. So try to make all the http requests in dev/run
use retries. That also helps us DRY out some repeating bits like header auth
and json application content type.

We also had an odd `import catch error then import again` clause. I don't think
we intend this to work on python 2 any longer so I cleaned that up as well.
Copy link
Contributor

@jaydoane jaydoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice cleanup!

Tested a couple different ways:

❯ dev/run -a adm:pass --with-haproxy --no-eval dev/remsh
[ * ] Setup environment ... ok
[ * ] Ensure CouchDB is built ... ok
[ * ] Ensure Erlang boot script exists ... ok
[ * ] Prepare configuration files ... ok
[ * ] Start node node1 ... ok
[ * ] Start node node2 ... ok
[ * ] Start node node3 ... ok
[ * ] Check node at http:https://127.0.0.1:15984/ ... ok
[ * ] Check node at http:https://127.0.0.1:25984/ ... ok
[ * ] Check node at http:https://127.0.0.1:35984/ ... ok
[ * ] Running cluster setup ... ok
[ * ] Exec command dev/remsh ... Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]

Enabled docsh 0.7.0 from: /Users/jay/repos/docsh/_build/default/lib/docsh
Call h(docsh) for interactive help.

Eshell V13.2.2  (abort with ^G)
([email protected])1>

and

❯ dev/run -a adm:pass --with-haproxy --with-clouseau --clouseau-dir ~/repos/clouseau --no-eval dev/remsh
[ * ] Setup environment ... ok
[ * ] Ensure CouchDB is built ... ok
[ * ] Ensure Erlang boot script exists ... ok
[ * ] Prepare configuration files ... ok
[ * ] Start node node1 ... ok
[ * ] Start node node2 ... ok
[ * ] Start node node3 ... ok
[ * ] Start Clouseau node clouseau1 ... ok
[ * ] Start Clouseau node clouseau2 ... ok
[ * ] Start Clouseau node clouseau3 ... ok
[ * ] Check node at http:https://127.0.0.1:15984/ ... ok
[ * ] Check Clouseau node clouseau1 ... failed: Clouseau is not working
[ * ] Check node at http:https://127.0.0.1:25984/ ... ok
[ * ] Check Clouseau node clouseau2 ... failed: Clouseau is not working
[ * ] Check node at http:https://127.0.0.1:35984/ ... ok
[ * ] Check Clouseau node clouseau3 ... failed: Clouseau is not working
[ * ] Check node at http:https://127.0.0.1:15984/ ... ok
[ * ] Check Clouseau node clouseau1 ... ok
[ * ] Check node at http:https://127.0.0.1:25984/ ... ok
[ * ] Check Clouseau node clouseau2 ... ok
[ * ] Check node at http:https://127.0.0.1:35984/ ... ok
[ * ] Check Clouseau node clouseau3 ... ok
[ * ] Running cluster setup ... ok
[ * ] Exec command dev/remsh ... Erlang/OTP 25 [erts-13.2.2] [source] [64-bit] [smp:10:10] [ds:10:10:10] [async-threads:1] [jit]

Enabled docsh 0.7.0 from: /Users/jay/repos/docsh/_build/default/lib/docsh
Call h(docsh) for interactive help.

Eshell V13.2.2  (abort with ^G)
(search)`ping': net_adm:ping('[email protected]').
([email protected])1> net_adm:ping('[email protected]').
pong

@nickva nickva merged commit 60f6805 into main Dec 7, 2023
14 checks passed
@nickva nickva deleted the more-flakes-in-cluster-setup branch December 7, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants