Simplify couch_changes_tests.erl using macro ?TDEF_FE
#4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiahuili430
force-pushed
the
refactor-couch-changes-tests
branch
6 times, most recently
from
7af2e1d
to
9b722cc
Compare
nickva
approved these changes
Dec 7, 2023
jiahuili430
force-pushed
the
refactor-couch-changes-tests
branch
from
9b722cc
to
1503e40
Compare
|
The The revision tree we create doesn't have to be too complex, just to cover at least one live conflict, one deleted conflict, and a deleted doc. I'll see if I can find an example on how to do as it can be a bit tricky... |
- Simplify `couch_changes_tests.erl` using macro `?TDEF_FE` - Re-enable testing: `filter_by_custom_function()` - Add `_changes` tests with style and include_docs
jiahuili430
force-pushed
the
refactor-couch-changes-tests
branch
from
1503e40
to
876cc7d
Compare
|
Sure, I will add more test cases. Thank you for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
couch_changes_tests.erlusing macro?TDEF_FEfilter_by_custom_function()_changestests with style and include_docsTesting recommendations
make eunit apps=couch suites=couch_changes_testsRelated Issues or Pull Requests
Checklist
rel/overlay/etc/default.inisrc/docsfolder