Relax restriction on [admins] in dev local.ini

[jaydoane]

Overview

Currently, dev/run only starts CouchDB if the [admins] section is last in local.ini. Otherwise, it will fail, and log this message:

[info] 2023-12-02T21:50:40.510174Z [email protected] <0.262.0> --------
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
  No Admin Account Found, aborting startup.
  Please configure an admin account in your local.ini file.
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

looking at the local.ini in question, we see:

[admins]
;admin = mysecretpassword
[foo]
bar = baz

adm = -pbkdf2:sha256-8b982d3bfcf15ded130fcfe721c34fe77cda990850d6ec42fb056fe4478c79a9,01d8d790d7fd4526bf342a90f706168f,10

where the admin user has been appended to the end of the file instead of in the [admins] section.

This relaxes that restriction by inserting the admin user just after the [admin] section line, rather than at the end of the file.

Testing recommendations

echo -e '[foo]\nbar = baz\n' >> rel/overlay/etc/local.ini
dev/run -a adm:pass 

should actually start, and e.g. tail -20 dev/lib/node1/etc/local.ini should contain something like

[admins]
adm = -pbkdf2:sha256-058897f910d5b0385621c8004ef340f570643d89fd7c9caf43823c917ad6112f,a97a639b0edb2842a7b9f907763c1b0b,50000
;admin = mysecretpassword
[foo]
bar = baz

Related Issues or Pull Requests

Checklist

• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• Documentation changes were made in the src/docs folder
• Documentation changes were backported (separated PR) to affected branches

[nickva]

+1

Python has a built-in ini parser at some time in the future we could probably use that instead of the hack_ini_local thing we have there.

[jaydoane]

+1

Python has a built-in ini parser at some time in the future we could probably use that instead of the hack_ini_local thing we have there.

Oh, nice. An actual parser would be a good idea. Thanks for the suggestion!