Look up search node name in config for weatherreport #4887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Weatherreport is hard-coded to assume the search node is at '[email protected]' and that it is running. This results in a useless warning for users that do not have search enabled, and also means that it will fail to connect if Clouseau is running somewhere other than 127.0.0.1. This replaces the hard-coded node name with a config lookup to `[dreyfus] name` and handles the case of it not being set.
rnewson
reviewed
Nov 30, 2023
| undefined -> | ||
| [{info, clouseau_not_configured}]; | ||
| _ -> | ||
| SearchNode = list_to_atom(SearchNodeStr), |
There was a problem hiding this comment.
needs to be list_to_existing_atom
There was a problem hiding this comment.
I've pushed one more commit that implements this, is it what you had in mind?
rnewson
requested changes
Nov 30, 2023
pgj
reviewed
Dec 1, 2023
| format({clouseau_ok, SearchNode}) -> | ||
| {"Local search node at ~w responding ok", [SearchNode]}; | ||
| format({clouseau_node, SearchNode}) -> | ||
| {"Search node name ~s is not recognised", [SearchNode]}; |
There was a problem hiding this comment.
"recognised" is the UK spelling. I think the US spelling ("recognized") is used in this project, but I may be wrong here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Weatherreport is hard-coded to assume the search node is at '[email protected]' and that it is running. This results in a useless warning for users that do not have search enabled, and also means that it will fail to connect if Clouseau is running somewhere other than 127.0.0.1.
This replaces the hard-coded node name with a config lookup to
[dreyfus] nameand handles the case of it not being set.Testing recommendations
On
main, runningweatherreportagainst my dev cluster prints this warning about Clouseau not responding, regardless of what[dreyfus] nameis set to:With this change, the above warning is not printed unless
[dreyfus] namehas been set:Checklist
rel/overlay/etc/default.inisrc/docsfolder