DRAFT nouveau deb/rpm packaging #4880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgj
reviewed
Nov 28, 2023
| into '/opt/nouveau' | ||
|
|
||
| from(jar.outputs.files) { | ||
| into 'lib' |
There was a problem hiding this comment.
The indentation is off here? At least compared to line 110 below.
pgj
reviewed
Nov 28, 2023
| ospackage { | ||
| packageName = 'nouveau' | ||
|
|
||
| into '/opt/nouveau' |
There was a problem hiding this comment.
Is not this something that could be controlled by a user-specified prefix? I am not experienced in building Debian packages, but for example, in case of FreeBSD, the prefix for the package can be configured by the user.
There was a problem hiding this comment.
install prefix is not configurable for debian packages. At least, I've never seen such a thing.
|
closing as this work will be done in couchdb-pkg instead. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.