Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vsn module attribute #4853

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Remove vsn module attribute #4853

merged 1 commit into from
Nov 16, 2023

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Nov 16, 2023

No description provided.

@nickva nickva merged commit d05a2dc into main Nov 16, 2023
14 checks passed
@nickva nickva deleted the remove-vsn-attributes branch November 16, 2023 20:21
@nickva nickva mentioned this pull request Nov 16, 2023
Merged
@janl
Copy link
Member

janl commented Nov 28, 2023

It would be great to explain why this was removed.

@nickva
Copy link
Contributor Author

nickva commented Nov 28, 2023

@janl sorry, good call that it should be explained better.

vsn attribute allows tagging modules with a custom version numbers. When omitted, the hash of the module contents becomes its version. The vsn argument is useful when performing hot code release upgrade. It helps keep track of gen_server states to allow custom upgrade / downgrade clauses.

We do not support hot code release upgrades (Cloudant did once) so these custom tags are outdated and just noise at this point, that's why it made sense to clean them up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnewson rnewson rnewson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nickva @janl @rnewson