Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exunit makefile target #4845

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Remove exunit makefile target #4845

merged 1 commit into from
Nov 13, 2023

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Nov 13, 2023

We don't have any exunit tests any longer but still spend time setting up and running exunit tests in CI.

@nickva
Remove exunit makefile target
c4ce6f0 
We don't have any exunit tests any longer but still spend time setting up and
running exunit tests in CI.
big-r81
big-r81 previously requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@big-r81 big-r81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx Nick.

Please remove it from Makefile.win too, if it exists.

@nickva
Copy link
Contributor Author

nickva commented Nov 13, 2023

@big-r81 the pr has it removed already :-) https://github.com/apache/couchdb/pull/4845/files#diff-10ed172a506448a217903c4ff9ddc9e6044d176b8d3ff409a59602494cf2397dL143-L175

@big-r81
Copy link
Contributor

big-r81 commented Nov 13, 2023

🫣

@big-r81 big-r81 dismissed their stale review November 13, 2023 19:51

Needs some glasses...

big-r81
big-r81 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@big-r81 big-r81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@nickva nickva merged commit c32ff68 into main Nov 13, 2023
14 checks passed
@nickva nickva deleted the remove-exunit branch November 13, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@big-r81 big-r81 big-r81 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickva @big-r81