Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for newly set admin creds to be hashed in setup #4834

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Nov 8, 2023

Previously, in the setup app, we set admin creds but didn't wait for them to be hashed. The next setup step then could fail with the 401 error.

Since we're doing setup, let's wait for the newly set creds to be hashed before continuing.

Previously, in the setup app, we set admin creds but didn't wait for them to be
hashed. The next setup step then could fail with the 401 error.

Since we're doing setup, let's wait for the newly set creds to be hashed before
continuing.
@nickva
Copy link
Contributor Author

nickva commented Nov 8, 2023

Set a very high iteration count then start ./dev/run -n 1 cluster with debug logging:

[debug] 2023-11-08T17:32:42.199629Z [email protected] <0.439.0> d57e910932 Waiting for admins to be hashed. Seconds left: 291
[debug] 2023-11-08T17:32:43.200672Z [email protected] <0.439.0> d57e910932 Waiting for admins to be hashed. Seconds left: 290
...

Copy link
Member

@rnewson rnewson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@nickva nickva merged commit be6124a into main Nov 8, 2023
14 checks passed
@nickva nickva deleted the wait-for-admin-passwords-to-be-hashed branch November 8, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants