fix: make elixir should match what we run in CI

[janl]

test(make): remove elixir target, rename elixir-suite to elixir

The elixir target should run the default set that passes all tests.
The old target ran search tests that would fail without a separate
clouseau setup step. The new elixir target is what we actually run
in CI. This should prevent developer confusion when things pass in CI
but fail locally or vice versa.

Before:

Because in make elixir dev/run is started without --with-nouveau,
but the newish --exclude nouveau option is conditional on whether
./configure was run with --enable-nouveau — what we really want is
to --exclude nouveau in make elixir unconditionally, because those
tests are run separately in make nouveau-test which does start dev/run
with nouveau correctly.

Also:
test: do not run clouseau tests by default

This introduces a new --enable-clouseau-tests option for ./configure
that selectively enables make elixir-search during make check.

Updates to our respective Jenkinsfiles to accommodate this.

This should have no functional difference in CI but make make elixir work on systems that do not have Clousau running.

[big-r81]

+1

[nickva]

Not sure if enabling clouseau would work with the current CI setup? I do not recall us setting up any dev/run or CI image clouseau bits, I think we'd need some of those things before we can enable these tests by default.

[janl]

my assumption was that clouseau must already be running as elixir tests fail without it. — the only other option is that we do not fail our build when elixir tests fail, which would be terrible

[nickva]

my assumption was that clouseau must already be running as elixir tests fail without it. — the only other option is that we do not fail our build when elixir tests fail, which would be terrible:

Ah that makes sense, @janl. We just never run make elixir in the CI. We run make elixir-suite. The default test suite doesn't include clouseau tests.

[janl]

thanks Nick, I finally got there independently. I suggest we remove the old elixir target and we rename elixir-suite to elixir

no longer relevant

[nickva]

+1