[shard splitting] allow resumption of failed jobs & make timeout configurable #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
big-r81
reviewed
Jul 19, 2023
janl
force-pushed
the
feat/improve-shard-splitting
branch
from
8c832de
to
1cd01af
Compare
nickva
reviewed
Jul 19, 2023
nickva
reviewed
Jul 19, 2023
janl
force-pushed
the
feat/improve-shard-splitting
branch
5 times, most recently
from
e7ea61d
to
8d641d0
Compare
nickva
reviewed
Jul 21, 2023
nickva
approved these changes
Jul 21, 2023
janl
force-pushed
the
feat/improve-shard-splitting
branch
from
199a656
to
c3f4c40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
failed jobs should be restartable, and with the ioq downgrade of reshard jobs, we need to make the timeout configurable, so busy clusters do not fail for no good reason.