optionally suppress version info in server response header #4613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnewson
force-pushed
the
server-header-versions
branch
from
6339386
to
df03bdb
Compare
nickva
requested changes
May 22, 2023
There was a problem hiding this comment.
Works as intended.
However, we should add it to the docs and the default.ini file.
([email protected])1> config:set("httpd", "send_server_header_versions", "false", false).
ok
% http $DB
HTTP/1.1 200 OK
Cache-Control: must-revalidate
Content-Length: 244
Content-Type: application/json
Date: Mon, 22 May 2023 16:10:28 GMT
Server: CouchDB
X-Couch-Request-ID: 7fa4c2f909
X-CouchDB-Body-Time: 0
...
df03bdb
to
cbc045f
Compare
nickva
reviewed
May 22, 2023
rnewson
force-pushed
the
server-header-versions
branch
from
cbc045f
to
93d7ee6
Compare
nickva
approved these changes
May 22, 2023
|
I'll merge this PR to avoid it needing another rebase + CI run wait as I have another smaller PR pending if that merged before this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to suppress including the CouchDB and OTP versions, defaulting to the current behaviour of including both.
note: If, instead, we omitted this line we would get Mochiweb's default server line rather than no server line.