Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nouveau mango integration #4589

Merged
merged 1 commit into from
May 10, 2023
Merged

Improve nouveau mango integration #4589

merged 1 commit into from
May 10, 2023

Conversation

rnewson
Copy link
Member

@rnewson rnewson commented May 10, 2023

Use lucene's "text" field type for the default field, the only one that supports $text

Add tests and fixes so we can sort on numbers and strings via mango also.

1) Fix sorting on strings and numbers
2) use 'string' type for string fields
3) use 'text' type for the default field
@rnewson rnewson force-pushed the nouveau-mango-string-text branch from 7cf36d9 to 51267a5 Compare May 10, 2023 13:44
@rnewson rnewson changed the title Support text field type for nouveau and error everything else Improve nouveau mango integration May 10, 2023
@rnewson
Copy link
Member Author

rnewson commented May 10, 2023

noting that the $text operator in mango is constrained to only be capable of phrase queries (the query you supply is unilaterally enclosed in double quotes) but this affects dreyfus / clouseau also.

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@rnewson rnewson merged commit f5935c6 into main May 10, 2023
@rnewson rnewson deleted the nouveau-mango-string-text branch May 10, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants