Revert "fix(mango): GET invalid path under _index
should not cause 500
#4584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c1195e4.
This wasn't quite right. handle_index_req has several separate resources handled within it which each support a different set of http methods.
We should send 405 for a resource that exists but doesn't support the request's method.
We should send 404 for a resource that doesn't exist at all.
Reverting this gives us a 500 / function_clause, which is at least honest (the server has made an error) but we should circle back and send better errors.
Noting that;
In conclusion, we handle invalid paths in request handlers inconsistently, which ironically frees us to do the right thing in handle_index_req