fix race condition when creating indexes #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickva
approved these changes
Apr 27, 2023
rnewson
force-pushed
the
nouveau-race-condition-creating-index
branch
2 times, most recently
from
a6951fb
to
d4f7fd4
Compare
rnewson
force-pushed
the
nouveau-race-condition-creating-index
branch
from
d4f7fd4
to
23dfab5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two concurrent attempts to create the same index can fail (in our case this is the fabric rpc worker racing against the ken worker). take a lock to prevent this, but use a striped pattern to allow some concurrency between independent index creations.