Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Fauxton and Docs git repo urls #453

Closed
wants to merge 1 commit into from
Closed

Conversation

garrensmith
Copy link
Member

@garrensmith garrensmith commented Mar 9, 2017

Update Git repos

Overview

Fauxton and Documentation are now using gitbox. This means we need to change the repository urls to use github.

Testing recommendations

./configure should now run

Checklist

  • Code is written and works correctly;
  • Changes are covered by tests;
  • Documentation reflects the changes;
  • I will not forget to update rebar.config.script
    with the correct commit hash once this PR get merged.

Copy link
Member

@janl janl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

For next time, please keep whitespace changes in a separate commit. It makes things easier to review :)

@lostnet
Copy link
Contributor

lostnet commented Mar 9, 2017

My automated builds are using anonymous clone over https, so git over ssh fails on the github hostkey, etc. Maybe https urls would work correctly for both configurations:

-{docs,             "documentation",    "59a887a97f9b6befc6de0c5bdaf17d79fb7f915d", [raw]},
+{docs,             {url, "https://github.com/apache/couchdb-documentation.git"},    "59a887a97f9b6befc6de0c5bdaf17d79fb7f915d", [raw]},
 {ddoc_cache,       "ddoc-cache",       "c762e90a33ce3cda19ef142dd1120f1087ecd876"},
 {ets_lru,          "ets-lru",          "c05488c8b1d7ec1c3554a828e0c9bf2888932ed6"},
 {fabric,           "fabric",           "d22903c0ceaf19a305e67b5b7322cbdc4e5e9340"},
-{fauxton,          "fauxton",          {tag, "v1.1.9"}, [raw]},
+{fauxton,          {url, "https://github.com/apache/couchdb-fauxton.git"},          {tag, "v1.1.9"}, [raw]},

@wohali
Copy link
Member

wohali commented Mar 9, 2017

I'm confused. Are the canonical URLs for our repos now at github.com or gitbox.apache.org? I thought it was the latter, which would make this PR incorrect.

@kxepal
Copy link
Member

kxepal commented Mar 9, 2017

I'm with @wohali.

@garrensmith
Copy link
Member Author

garrensmith commented Mar 9, 2017 via email

@janl
Copy link
Member

janl commented Mar 9, 2017

It's both, but it seems the preferred way is to use the github repo's and use gitbox as a fallback

There is no preferred way. Individual developers can pick either route.

As for where the canonical source for CouchDB lives, it is clearly gitbox.

@garrensmith
Copy link
Member Author

I'm closing this. @nickva did a much better fix and its in master

@garrensmith garrensmith deleted the update-git-repos branch March 10, 2017 06:36
nickva pushed a commit to nickva/couchdb that referenced this pull request Sep 7, 2022
Add autoupdate field to design docs API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants