Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(mac): re-enable mac CI for the full build #4387

Merged
merged 4 commits into from
Jan 19, 2023
Merged

ci(mac): re-enable mac CI for the full build #4387

merged 4 commits into from
Jan 19, 2023

Conversation

janl
Copy link
Member

@janl janl commented Jan 18, 2023

Overview

Testing recommendations

Related Issues or Pull Requests

Checklist

  • Code is written and works correctly
  • Changes are covered by tests
  • Any new configurable parameters are documented in rel/overlay/etc/default.ini
  • Documentation changes were made in the src/docs folder
  • Documentation changes were backported (separated PR) to affected branches

@nickva
Copy link
Contributor

nickva commented Jan 18, 2023

Use the jenkins-*-like branch name so the full CI will run on the PR. That's a good way to test full CI changes in a PR.

Copy link
Contributor

@big-r81 big-r81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for enabling macos again, Jan.

I tried my suggestion building the full CI and see that it failed #4389

https://ci-couchdb.apache.org/blue/organizations/jenkins/jenkins-cm1%2FFullPlatformMatrix/detail/jenkins-ci-enable-mac/1/pipeline/80

[2023-01-18T19:06:28.709Z] + ./configure --skip-deps --spidermonkey-version 91

[2023-01-18T19:06:28.709Z] ./configure: line 36: erl: command not found

script returned exit code 127

@janl
Copy link
Member Author

janl commented Jan 19, 2023

PATH issue, thanks!

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2023-01-19 at 12 23 39 PM

Well done +1

@nickva nickva merged commit 3b6ebde into main Jan 19, 2023
@nickva nickva deleted the ci/enable-mac branch January 19, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants