Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): fail build if xref complains #4349

Merged
merged 1 commit into from
Jul 31, 2023
Merged

feat(build): fail build if xref complains #4349

merged 1 commit into from
Jul 31, 2023

Conversation

janl
Copy link
Member

@janl janl commented Jan 5, 2023

only works on Erlang 23. 24 and 25 fail

24 e.g. with:

Warning: hastings_index:await/2 is undefined function (Xref)
Warning: hastings_index:design_doc_to_indexes/1 is undefined function (Xref)
Warning: hastings_index_manager:get_index/2 is undefined function (Xref)
WARN:  Continuing on after abort: [xref]
ERROR: xref failed while processing /Users/jan/Work/asf/tmp/couchdb/src/mem3: {'EXIT',
 {{badmatch,
   [{attribute,{1,1},file,{"src/mem3_reshard_index.erl",1}},
    {attribute,{13,2},module,mem3_reshard_index},
    {attribute,
     {15,2},
     export,
     [{design_docs,1},{target_indices,2},{spawn_builders,1},{build_index,2}]},
… big symbol dump

@janl janl marked this pull request as draft January 5, 2023 11:40
build-aux/xref-helper.sh Outdated Show resolved Hide resolved
@janl janl marked this pull request as ready for review July 29, 2023 10:31
@janl janl force-pushed the feat/xref-fails-build branch 2 times, most recently from c8421d1 to bfa0e03 Compare July 31, 2023 09:35
@janl janl merged commit 6b9e5bf into main Jul 31, 2023
14 checks passed
@janl janl deleted the feat/xref-fails-build branch July 31, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants