Clean up ./dev/run output #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -355,6 +355,7 @@ def check_node_alive(url): | |||
| try: | |||
| with contextlib.closing(urlopen(url)): | |||
| pass | |||
| error = None | |||
There was a problem hiding this comment.
Logically, it should be in else block.
There was a problem hiding this comment.
Agree, good point. Will move it to else block.
|
+1 |
If connection succeeds eventually, don't report spurious error when retrying. Turns `./dev/run` output from this: ``` [ * ] Check node at https://127.0.0.1:15984/ ... failed: [Errno socket error] [Errno 111] Connection refused [ * ] Check node at https://127.0.0.1:25984/ ... ok [ * ] Check node at https://127.0.0.1:35984/ ... ok [ * ] Check node at https://127.0.0.1:15984/ ... ok ``` to this: ``` [ * ] Check node at https://127.0.0.1:15984/ ... ok [ * ] Check node at https://127.0.0.1:25984/ ... ok [ * ] Check node at https://127.0.0.1:35984/ ... ok ``` Cleaner and a bit less scary for new developers.
9993555
to
9620ff6
Compare
nickva
pushed a commit
to nickva/couchdb
that referenced
this pull request
Sep 7, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If connection succeeds eventually, don't report spurious error when retrying.
Turns
./dev/runoutput from this:to this:
Cleaner and a bit less scary for new developers.