Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up unit tests #4189

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Clean up unit tests #4189

merged 1 commit into from
Sep 28, 2022

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Sep 28, 2022

  • Centralize the definition of TDEF* macros

  • Don't include eunit bits in the fabric at the top, instead use TEST specific sections

  • Remove some unused include files, as reported by erlang_ls + emacs

Copy link
Contributor

@jaydoane jaydoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

@nickva nickva force-pushed the cleanup-fabric-tests branch 8 times, most recently from 0fc74b7 to 24043e0 Compare September 28, 2022 21:53
 * Centralize the definition of TDEF* macros

 * Don't include eunit bits in the fabric at the top, instead use TEST specific
   sections

 * Remove some unused include files, as reported by erlang_ls + emacs
@nickva nickva merged commit 1407a51 into main Sep 28, 2022
@nickva nickva deleted the cleanup-fabric-tests branch September 28, 2022 22:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants