Enforce row limit in mango #3881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonysun83
reviewed
Dec 20, 2021
tonysun83
reviewed
Dec 20, 2021
rnewson
force-pushed
the
enforce_rowlimit_mango
branch
from
d81d598
to
dd43774
Compare
|
jenkins requires |
rnewson
force-pushed
the
enforce_rowlimit_mango
branch
from
b109c9b
to
fdabc4e
Compare
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
We specify two config variables under query_server_config called partition_query_limit and query_limit. These are not enforced in the code since b2f9cfa was merged in response to issue #2795.
The right fix is to move the enforcement to later in the mango execution sequence.
Testing recommendations
Related Issues or Pull Requests
#2795
Checklist
rel/overlay/etc/default.ini