Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create couch_lib application #3857

Closed
wants to merge 1 commit into from
Closed

Conversation

iilyak
Copy link
Contributor

@iilyak iilyak commented Dec 2, 2021

Overview

This is a cherry-pick of a 845f917 from main into 3.x.

Testing recommendations

Usual ./configure && make would be sufficient since this commit doesn't provide new functionality.

Related Issues or Pull Requests

Checklist

@nickva
Copy link
Contributor

nickva commented Dec 3, 2021

Wonder if it would make sense to add/move some functions to it as it seems a bit odd to commit an empty application. Or, do you think it's better to first have the app first, then plan on moving helper functions into it?

Just afraid most committers won't even know about it and will just keep adding functions to couch_util and the app will just stay empty for quite a while.

@iilyak
Copy link
Contributor Author

iilyak commented Dec 3, 2021

Wonder if it would make sense to add/move some functions to it as it seems a bit odd to commit an empty application. Or, do you think it's better to first have the app first, then plan on moving helper functions into it?

Just afraid most committers won't even know about it and will just keep adding functions to couch_util and the app will just stay empty for quite a while.

The original PR #3529 contained some functions.

  • couch_lib_parse:parse_boolean/1 - parses given string or binary into Erlang's boolean() type
  • couch_lib_parse:parse_integer/1 - parses given string as Erlang's integer() type
  • couch_lib_parse:parse_non_neg_integer/1 - parses given string as Erlang's non_neg_integer() type ([0..infinity))

However I was afraid pulling them here since there is no immediate need in them.

@rnewson
Copy link
Member

rnewson commented Dec 3, 2021

There is nothing in couch_lib, what is the value of this work?

Copy link
Member

@rnewson rnewson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until this actually does something, -1.

@janl janl closed this Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants