CouchDB 3.x: Move config options from [httpd] to [chttpd]

[jiahuili430]

Overview

Move some configuration options from [httpd] to [chttpd].
The options are kept in [httpd]: port, bind_address, authentication_handlers, server_options and socket_options.
Since users have local settings, we cannot just move all options directly to [chttpd].
chttpd_util: get_chttpd_config() will first check [chttpd], if it is not defined, it will check [httpd], and then, if it is not defined, it will return the Default value.

I will add a documentation PR after when I finished moving options from [couch_httpd_auth] to [chttpd_auth].

Testing recommendations

make eunit apps=chttpd suites=chttpd_util_test

Related Issues or Pull Requests

This fixes #3472

Checklist

• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

[nickva]

Nice work @jiahuili430!

The PR looks great. Just a few cosmetic changes line lengths, a few boolean config switches, cleaning up chttpd_auth bits.

For new modules at least let's try to keep to a consistent style - line lengths less than 80 columns, proper whitespacing. A good way to check for those is to run Emilio (https://github.com/cloudant-labs/emilio).

Here is an example of a the type of output it might produce:

/Users/nvatama/asf (main) % ~/src/emilio/emilio ~/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:19(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:20(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:20(72) - 601 - underscore varibale _Persist reused
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:21(56) - 601 - underscore varibale _Persist reused
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:22(56) - 601 - underscore varibale _Persist reused
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:22(74) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:26(58) - 601 - underscore varibale _Persist reused
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:27(51) - 601 - underscore varibale _Persist reused
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:28(52) - 601 - underscore varibale _Persist reused
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:28(70) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:46(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:50(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:51(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:55(7) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:58(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:59(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:60(74) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:64(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:69(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:70(75) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:76(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:76(95) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:81(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:83(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:84(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:84(93) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:89(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:91(63) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:94(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:94(104) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:97(71) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:100(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:101(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:102(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:103(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:104(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:104(86) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:107(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:108(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:109(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:110(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:110(119) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/test/eunit/chttpd_util_test.erl:112(1) - 501 - line longer than 80 characters
/Users/nvatama/asf (main) %
/Users/nvatama/asf (main) %
/Users/nvatama/asf (main) %
/Users/nvatama/asf (main) % ~/src/emilio/emilio ~/asf-3/src/chttpd/src/chttpd_util.erl
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:17(26) - 130 - export at column 26, not 5
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:18(34) - 130 - export at column 34, not 5
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:19(31) - 130 - export at column 31, not 5
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:25(49) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:29(58) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:31(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:33(66) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:35(1) - 501 - line longer than 80 characters
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:37(66) - 302 - there should be 2 empty lines between functions, not 1
/Users/nvatama/asf-3/src/chttpd/src/chttpd_util.erl:41(60) - 302 - there should be 2 empty lines between functions, not 1

[nickva]

@jiahuili430 In the light of almost merging the erlfmt formatting PR, I think let's not worry about line length and emilio formatting as all that will be done automatically afterwards and it makes things simpler for you.

[nickva]

One minor test fix-up and then +1

Great work @jiahuili430

[iilyak]

What was the reason to use atom for keys?

[jiahuili430]

To simplify the code. Otherwise, I need to use the key with quotation marks.
Thanks for the review.

[tonysun83]

I noticed that previously we were doing something like:

config:get("httpd", "enable_cors", "false")

Similar to what @iilyak asked above, was there a specific reason you decided to convert the string key/value pairs into boolean/integer, but then convert them back to with atom_to_list? Was it to make it more organized between different types?

[jiahuili430]

Thanks for your review, considering the price of type conversion, I will change them back to strings.

[nickva]

Nice work @jiahuili430