Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix check_local_dbs test #3253

Merged
merged 1 commit into from
Nov 9, 2020
Merged

fix check_local_dbs test #3253

merged 1 commit into from
Nov 9, 2020

Conversation

jiangphcn
Copy link
Contributor

Overview

This is to fix the possible failure of mem3_seeds_test: a_test_ (optional local _users db in mem3_sync:local_dbs())...[0.029 s] ok because local databases do not always include _dbs and _nodes.

Testing recommendations

make check skip_deps+=couch_epi apps=mem3

Related Issues or Pull Requests

Checklist

@jiangphcn jiangphcn requested a review from nickva November 9, 2020 03:27
nickva
nickva approved these changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find and thanks for fixing it
+1

@jiangphcn jiangphcn merged commit 9a0c55b into 3.x Nov 9, 2020
@jiangphcn jiangphcn deleted the check_local_dbs branch November 9, 2020 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickva nickva nickva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangphcn @nickva