Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port users_db_security javascript tests to elixir #3190

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

jjrodrig
Copy link
Contributor

@jjrodrig jjrodrig commented Oct 5, 2020

Overview

This PR ports users_db_security.js tests into the elixir test suite. During the porting of this test I needed to add support for raw responses to Couch.Session module.

This is the last active test to be ported from the javascript test suite. The javascript test suite can be removed from the main build process as there are no more test being ran. I'll prepare a separate PR for this.

Testing recommendations

make javascript All test should be skipped or ported
make elixir All test should pass

Related Issues or Pull Requests

N/A

Checklist

@dottorblaster
Copy link
Member

Tests are red 🚨 did the modification to couch.ex affect some older stuff maybe?

@jjrodrig
Copy link
Contributor Author

jjrodrig commented Oct 5, 2020

oops... The problem with this test is that it is using _users database. If I'm not properly cleaning it we can have a side effect... I'll check it.

couch.ex changes are not the problem here. It's the execution order.

@dottorblaster
Copy link
Member

Thanks for checking!

@jjrodrig
Copy link
Contributor Author

jjrodrig commented Oct 5, 2020

I've rewritten the test cleaning process. I remove each user that has been previously created.
Now, it does not collide with any other test.
Thanks!

@jjrodrig jjrodrig merged commit de35260 into apache:master Oct 5, 2020
@jjrodrig
Copy link
Contributor Author

jjrodrig commented Oct 5, 2020

Thanks!! the last one 🎉

@wohali
Copy link
Member

wohali commented Oct 5, 2020

@jjrodrig is that the last JS test now?

If so, I can start the work to rip the JS test harness out of our build chain, makefiles, etc.

@jjrodrig
Copy link
Contributor Author

jjrodrig commented Oct 5, 2020

@wohali I'm just creating a PR that removes @$(MAKE) javascript from the check target

There are some tests that have not been ported. These tests are currently skipped in the JS test suite. I think that the work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants