Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stale=false for views #3120

Closed
wants to merge 1 commit into from

Conversation

bessbd
Copy link
Member

@bessbd bessbd commented Sep 1, 2020

Overview

The docs mention an option of "false" for "stale" which is currently not supported and is rejected by validation.

This commit fixes the problem described above.

Testing recommendations

make eunit apps=couch_mrview suites=couch_mrview_http

Related Issues or Pull Requests

N/A

Checklist

The docs mention an option of "false" for "stale" which is currently not supported and is rejected by validation.

This commit fixes the problem described above.
Copy link
Member

@eiri eiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1. This introduces new behaviour for deprecated query parameter stale, that while defaults to false never accepted it as a parameter before.

Since it's both 1) inconsistent with rest of the parameters "ok", "update_after" that are strings 2) is no-op, because it is just a default behaviour I suggest instead to update docs to remove ambiguity there.

@wohali
Copy link
Member

wohali commented Sep 1, 2020

I agree with @eiri here. The stale parameter was supposed to be deprecated in 3.x, but we gave it a reprieve until 4.0 (and maybe beyond that).

@bessbd
Copy link
Member Author

bessbd commented Sep 1, 2020

Thank you for the feedback, @eiri and @wohali . I'll close this PR and open a new one for docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants