Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: Build couch_js for redhat linux #3057

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

jiangphcn
Copy link
Contributor

@jiangphcn jiangphcn commented Aug 5, 2020

Overview

When building couch_js in RHEL, there is one error occurring with "undefined reference to symbol '_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3'". This commit is to adjust binding library to address this issue.

Compiling priv/couch_ejson_compare/couch_ejson_compare.c
/usr/bin/ld: priv/couch_js/60/main.o: undefined reference to symbol '_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3'
//usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
ERROR: sh(cc priv/couch_js/60/http.o priv/couch_js/60/main.o priv/couch_js/60/utf8.o priv/couch_js/60/util.o -L/usr/local/lib -std=c++14 -lmozjs-60 -lm   -L"/usr/local/lib/erlang/lib/erl_interface-3.10.2.2/lib" -lerl_interface -lei -o priv/couchjs)
failed with return code 1 and the following output:
/usr/bin/ld: priv/couch_js/60/main.o: undefined reference to symbol '_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3'
//usr/lib64/libstdc++.so.6: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

Testing recommendations

make, and make fdb-check in RHEL

Related Issues or Pull Requests

Checklist

@@ -118,6 +118,11 @@ end,
"-DXP_UNIX -I/usr/include/mozjs-60 -I/usr/local/include/mozjs-60 -std=c++14",
"-L/usr/local/lib -lmozjs-60 -lm -std=c++14 -lc++"
};
{unix, linux} when SMVsn == "60" ->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiangphcn thanks for this, what happens if we just add -lstdc++ to the {unix, _} case? Does it break other Linux builds? Or, is there a reason the -std=c++14 line won't work on RHEL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wohali thanks for your question and suggestion. I tested with Centos and Debian, and it will not break if we just add -lstdc++ to the {unix, _} case. I change accordingly. Could you please check again?

When building couch_js in RHEL, there is one error occurring with "undefined
 reference to symbol '_ZTVN10__cxxabiv117__class_type_infoE@@CXXABI_1.3'".
This commit is to adjust binding library to address this issue.
@jiangphcn jiangphcn force-pushed the build-fdb-couchjs-for-redhat-linux branch from 2916462 to 042347e Compare August 6, 2020 06:39
@jiangphcn jiangphcn merged commit dff8bc9 into prototype/fdb-layer Aug 6, 2020
@jiangphcn jiangphcn deleted the build-fdb-couchjs-for-redhat-linux branch August 6, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants