fix: finish_cluster failure due to missing uuid

[YC]

Resolves #2858

Overview

Fixes cluster setup failure when uuid is not set.
Added code to call couch_server:get_uuid() to ensure that uuid is set.

Testing recommendations

Sample docker-compose file

version: '3'
services:
  couch1:
    image: couchdev
#    image: couchdb:3
    environment:
      - COUCHDB_USER=user
      - COUCHDB_PASSWORD=pass
      - COUCHDB_SECRET=secret
      - NODENAME=10.0.0.10
    networks:
      couch:
        ipv4_address: 10.0.0.10
    command: "-setcookie cookie"
    volumes:
      - ./data1:/opt/couchdb/data

  couch2:
    image: couchdev
#    image: couchdb:3
    environment:
      - COUCHDB_USER=user
      - COUCHDB_PASSWORD=pass
      - COUCHDB_SECRET=secret
      - NODENAME=10.0.0.11
    networks:
      couch:
        ipv4_address: 10.0.0.11
    command: "-setcookie cookie"
    volumes:
      - ./data2:/opt/couchdb/data

networks:
    couch:
      driver: bridge
      ipam:
        config:
          - subnet: 10.0.0.0/16

Sample script

# curl http:https://10.0.0.10:5984
# curl http:https://10.0.0.11:5984
curl http:https://user:[email protected]:5984/_cluster_setup

curl --request POST \
  --url http:https://user:[email protected]:5984/_cluster_setup \
  --header 'content-type: application/json' \
  --data '{
	"action": "enable_cluster",
	"bind_address": "0.0.0.0",
	"username": "user",
	"password": "pass",
	"port": 5984,
	"node_count": 2,
	"remote_node": "10.0.0.11",
	"remote_current_user": "user",
	"remote_current_password": "pass"
}'
curl --request POST \
  --url http:https://user:[email protected]:5984/_cluster_setup \
  --header 'content-type: application/json' \
  --data '{
    "action": "add_node",
    "host": "10.0.0.11",
    "port": 5984,
    "username": "user",
    "password": "pass",
    "singlenode": false
}'
# curl http:https://couchdb1:5984/
curl --request POST \
  --url http:https://user:[email protected]:5984/_cluster_setup \
  --header 'content-type: application/json' \
  --data '{ "action": "finish_cluster" }'
curl http:https://user:[email protected]:5984/_cluster_setup

Related Issues or Pull Requests

#2797 #2858

Checklist

• Code is written and works correctly
• Changes are covered by tests
• Any new configurable parameters are documented in rel/overlay/etc/default.ini
• A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation

[janl]

perfect, thanks!