Import jwtf #2658
Merged
Import jwtf #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test does not pass yet.
* remove dependency on config * make checks optional * support HS256
and make everything truly optional.
* Improve pubkey not found error handling
When the public key identified by the {Alg, KID} tuple is not found on
the IAM keystore server, it's possible to see errors like:
([email protected])140> epep:jwt_decode(SampleJWT).
** exception error: no function clause matching
public_key:do_verify(<<"eyJ0eXAiOiJKV1QiLCJhbGciOiJSUzI1NiIsImtpZCI6IjIwMTcwNTIwLTAwOjAwOjAwIn0.eyJpc3MiOiJodHRwOi8vbG9jYWxob3N0OjEyMzIx"...>>,
sha256,
<<229,188,162,247,201,233,118,32,115,206,156,
169,17,221,78,157,161,147,46,179,42,219,66,
15,139,91,...>>,
{error,not_found}) (public_key.erl, line 782)
in function jwtf:public_key_verify/4 (src/jwtf.erl, line 212)
in call from jwtf:decode/3 (src/jwtf.erl, line 30)
Modify key/1 and public_key_not_found_test/0 to account for keystore
changing from returning an error tuple to throwing one.
Tolerate 5 crashes per 10 seconds
Improve restart strategy
Implement encode
Simplify tests
Move key cache to epep
Currently jwtf tests don't run in a continuous integration environment, presumably due to dependency rules. This splits the tests into their own module, but requires exposing a couple new functions in jwtf to support them. Some long lines were also broken into smaller lengths.
Separate tests into dedicated module
Recent changes in how `jiffy:decode/1` handles malformed JSON has caused `jwtf:decode/3` to fail to properly return a bad request 400 response for some malformed tokens. First, this changes the name of the function to `decode_b64url_json/1`, indicating that it decodes something that has been first been JSON encoded, and then base64url encoded. More substantially, it wraps both the base64url and jiffy decoding in a try/catch block, since both can throw errors, while the former can also return an error tuple. Tests have been added to ensure all code paths are covered.
Handle malformed tokens with jiffy 1.x
janl
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Import IBM Cloudant's JWT library (jwtf) including history.
Testing recommendations
N/A
Related Issues or Pull Requests
N/A
Checklist
rel/overlay/etc/default.ini