Fix/single node status #2581
Merged
Fix/single node status #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 91ecf67.
gesellix
reviewed
Feb 19, 2020
| SingleNodeConfig = config:get_boolean("couchdb", "single_node", false), | ||
| case SingleNodeConfig of | ||
| true -> | ||
| chttpd:send_json(Req, 200, {[{state, single_node_enabled}]}); |
There was a problem hiding this comment.
setup:is_single_node_enabled(Dbs) isn't necessary, because we expect the single_node setup to work?
There was a problem hiding this comment.
@gesellix yeah it’s a tiny bit of a fudge, I hoped we can get away with it :)
There was a problem hiding this comment.
if this ends up causing an issue in practice, we can add another clause there, but then we also need to invent a new state like single_node_pending or something and I didn’t want to get this in this late in the game.
nickva
force-pushed
the
fix/single-node-status
branch
from
8269b43
to
95e2c6a
Compare
nickva
force-pushed
the
fix/single-node-status
branch
from
95e2c6a
to
28d0f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really fix #2557