Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port etags tests into elixir test suite #2464

Closed
wants to merge 8 commits into from

Conversation

jjrodrig
Copy link
Contributor

@jjrodrig jjrodrig commented Jan 16, 2020

Overview

This PR ports etags_head test into exlixir test suite. I've checked the etags_views.js but it currently disabled in the js test suite so I have not included it in the port.

Testing recommendations

make elixir tests=test/elixir/test/etags_head.exs

Related Issues or Pull Requests

Checklist

nickva pushed a commit that referenced this pull request Jan 17, 2020
nickva pushed a commit that referenced this pull request Jan 18, 2020
@nickva
Copy link
Contributor

nickva commented Jan 18, 2020

@jjrodrig thank you for your contribution

Test looks good. I added two small fixes to it:

diff --git a/test/elixir/lib/couch.ex b/test/elixir/lib/couch.ex
index 994b68173..3aef07f01 100644
--- a/test/elixir/lib/couch.ex
+++ b/test/elixir/lib/couch.ex
@@ -110,7 +110,7 @@ defmodule Couch do
     end
   end

-  def process_response_body(headers, body) when body == [] do
+  def process_response_body(_headers, body) when body == [] do
     ""
   end

diff --git a/test/javascript/tests/etags_head.js b/test/javascript/tests/etags_head.js
index 9faca4af6..6cb99e40d 100644
--- a/test/javascript/tests/etags_head.js
+++ b/test/javascript/tests/etags_head.js
@@ -11,6 +11,7 @@
 // the License.

 couchTests.etags_head = function(debug) {
+  return console.log('done in tests=test/elixir/test/etags_head_test.exs');
   var db_name = get_random_db_name();
   var db = new CouchDB(db_name, {"X-Couch-Full-Commit":"false"});
   db.createDb();

Then squashed them into one commit and pushed them to the new PR #2469

Copy link
Contributor

@nickva nickva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Thank you.

I'll move rebase and fixed up the changes then merge them from a separate PR (since I can't push to your branch)

@nickva nickva closed this in aecf879 Jan 18, 2020
@jjrodrig jjrodrig deleted the port-elixir-etags branch May 27, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants