Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address flaky test failure on t_invalid_view/1 #2432

Merged
merged 1 commit into from
Jan 9, 2020

Conversation

jiangphcn
Copy link
Contributor

@jiangphcn jiangphcn commented Jan 9, 2020

Overview

Start couch_log to make sure that couch_log_server process exists and is able to write log instead of getting noproc error during test.

  smoosh_server:585: t_invalid_view...*failed*
in function gen_server:call/2 (gen_server.erl, line 206)
in call from couch_log:log/3 (src/couch_log.erl, line 73)
in call from smoosh_server:get_priority/2 (src/smoosh_server.erl, line 329)
in call from smoosh_server:'-t_invalid_view/1-fun-0-'/2 (src/smoosh_server.erl, line 587)
in call from smoosh_server:'-t_invalid_view/1-fun-3-'/2 (src/smoosh_server.erl, line 587)
**exit:{noproc,{gen_server,call,
                    [couch_log_server,
                     {log,{log_entry,warning,<0.32767.3>,
                                     [70,97,105,108,101,100|...],
                                     "--------",
                                     ["2020",45,[[...]|...],45|...]}}]}}
  output:<<"">>

Testing recommendations

make check apps=smoosh
  smoosh_server:520: t_ratio_view...[0.007 s] ok
  smoosh_server:530: t_slack_view...[0.007 s] ok
  smoosh_server:540: t_no_data_view...[0.007 s] ok
  smoosh_server:550: t_below_min_priority_view...[0.007 s] ok
  smoosh_server:560: t_below_min_size_view...[0.007 s] ok
  smoosh_server:570: t_timeout_view...[0.008 s] ok
  smoosh_server:580: t_missing_view...[0.007 s] ok
  smoosh_server:588: t_invalid_view...[0.007 s] ok

Related Issues or Pull Requests

Checklist

Copy link
Member

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@davisp
Copy link
Member

davisp commented Jan 9, 2020

I killed the build since I just merged to master. I pinged @jiangphcn to update.

- Start couch_log to make sure that couch_log_server proc exists
and write log instead of getting noproc error during test
@jiangphcn
Copy link
Contributor Author

rebased and waiting for CI happy to merge :-)

@davisp davisp merged commit 628e757 into master Jan 9, 2020
@davisp davisp deleted the address-flaky-t_invalid_view branch January 9, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants