Fix timeout case clause in fabric_db_info #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unlike most other fabric_db_* message handlers, the accumulator
for fabric_db_info has 3 terms. When a rexi timeout occurs, it
returns `{timeout, Accumulator}`; the case clause handling this
needs to expect 3 terms in the Accumulator instead of 2.
Fixes #2350
eiri
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Unlike most other fabric_db_* message handlers, the accumulator
for fabric_db_info has 3 terms. When a rexi timeout occurs, it
returns
{timeout, Accumulator}; the case clause handling thisneeds to expect 3 terms in the Accumulator instead of 2.
Testing recommendations
I can't see a good precedent for testing this but I'm happy to add a test if somebody can point me to an example.
Related Issues or Pull Requests
Fixes #2350
Checklist
rel/overlay/etc/default.ini